Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3832)

Unified Diff: chrome/browser/chromeos/settings/device_settings_service.cc

Issue 295103013: Add UMA for policy load result of enrolled Chrome OS devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/device_settings_service.cc
diff --git a/chrome/browser/chromeos/settings/device_settings_service.cc b/chrome/browser/chromeos/settings/device_settings_service.cc
index 0c54895c9f00739be934aeace13337c440b5c951..f60d41f1ed370b2bb7453a46fad19bc415729f46 100644
--- a/chrome/browser/chromeos/settings/device_settings_service.cc
+++ b/chrome/browser/chromeos/settings/device_settings_service.cc
@@ -351,7 +351,7 @@ void DeviceSettingsService::HandleCompletedOperation(
load_retries_left_ = kMaxLoadRetries;
} else if (status != STORE_KEY_UNAVAILABLE) {
LOG(ERROR) << "Session manager operation failed: " << status;
- // Validation errors can be temprary if the rtc has went on holiday for a
+ // Validation errors can be temporary if the rtc has gone on holiday for a
// short while. So we will retry such loads for up to 10 minutes.
if (status == STORE_TEMP_VALIDATION_ERROR) {
if (load_retries_left_ > 0) {
@@ -362,6 +362,10 @@ void DeviceSettingsService::HandleCompletedOperation(
FROM_HERE,
base::Bind(&DeviceSettingsService::Load, base::Unretained(this)),
base::TimeDelta::FromMilliseconds(kLoadRetryDelayMs));
+ } else {
+ // Once we've given up retrying, the validation error is not temporary
+ // anymore.
+ store_status_ = STORE_VALIDATION_ERROR;
}
}
}

Powered by Google App Engine
This is Rietveld 408576698