Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

Issue 295103013: Add UMA for policy load result of enrolled Chrome OS devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix has_dm_token conditional. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc b/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
index 70434098c7126d4cd19a96481ec20ce40a8064a6..3796efdd7fa6a16ba4e06f8ce3e1766a4afe8c4d 100644
--- a/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
+++ b/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h"
#include "base/bind.h"
+#include "base/metrics/histogram.h"
#include "base/sequenced_task_runner.h"
#include "chrome/browser/chromeos/policy/device_policy_decoder_chromeos.h"
#include "chrome/browser/chromeos/policy/enterprise_install_attributes.h"
@@ -22,6 +23,7 @@ DeviceCloudPolicyStoreChromeOS::DeviceCloudPolicyStoreChromeOS(
: device_settings_service_(device_settings_service),
install_attributes_(install_attributes),
background_task_runner_(background_task_runner),
+ uma_done_(false),
weak_factory_(this) {
device_settings_service_->AddObserver(this);
}
@@ -133,6 +135,20 @@ void DeviceCloudPolicyStoreChromeOS::UpdateFromService() {
return;
}
+ // Fill UMA histogram once per session. Skip temp validation error because it
+ // is not a definitive result (policy load will be retried).
+ const chromeos::DeviceSettingsService::Status status =
+ device_settings_service_->status();
+ if (!uma_done_ &&
+ status != chromeos::DeviceSettingsService::STORE_TEMP_VALIDATION_ERROR) {
+ uma_done_ = true;
+ const bool has_dm_token =
+ status == chromeos::DeviceSettingsService::STORE_SUCCESS &&
+ device_settings_service_->policy_data() &&
+ device_settings_service_->policy_data()->has_request_token();
+ UMA_HISTOGRAM_BOOLEAN("Enterprise.EnrolledPolicyHasDMToken", has_dm_token);
+ }
+
switch (device_settings_service_->status()) {
case chromeos::DeviceSettingsService::STORE_SUCCESS: {
status_ = STATUS_OK;

Powered by Google App Engine
This is Rietveld 408576698