Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 295103009: [chromedriver] Add 36 to test suite and remove 33 (Closed)

Created:
6 years, 7 months ago by samuong
Modified:
6 years, 7 months ago
Reviewers:
stgao, srawlins
CC:
chromium-reviews, srawlins
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[chromedriver] Add 36 to test suite and remove 33 BUG= NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272320

Patch Set 1 #

Total comments: 2

Patch Set 2 : 35 -> 36 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/test/chromedriver/archive.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test/run_all_tests.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
samuong
6 years, 7 months ago (2014-05-22 20:10:31 UTC) #1
srawlins
https://codereview.chromium.org/295103009/diff/1/chrome/test/chromedriver/test/run_all_tests.py File chrome/test/chromedriver/test/run_all_tests.py (right): https://codereview.chromium.org/295103009/diff/1/chrome/test/chromedriver/test/run_all_tests.py#newcode194 chrome/test/chromedriver/test/run_all_tests.py:194: ['35', archive.CHROME_36_REVISION], Should this be '36'?
6 years, 7 months ago (2014-05-22 20:48:28 UTC) #2
samuong
https://codereview.chromium.org/295103009/diff/1/chrome/test/chromedriver/test/run_all_tests.py File chrome/test/chromedriver/test/run_all_tests.py (right): https://codereview.chromium.org/295103009/diff/1/chrome/test/chromedriver/test/run_all_tests.py#newcode194 chrome/test/chromedriver/test/run_all_tests.py:194: ['35', archive.CHROME_36_REVISION], On 2014/05/22 20:48:28, srawlins wrote: > Should ...
6 years, 7 months ago (2014-05-22 20:51:08 UTC) #3
stgao
lgtm
6 years, 7 months ago (2014-05-22 21:19:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/295103009/20001
6 years, 7 months ago (2014-05-22 21:19:37 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 21:27:58 UTC) #6
Message was sent while issue was closed. 
Change committed as 272320

Powered by Google App Engine
This is Rietveld 408576698