Issue 295103008: If our gyp does not exist, use chromium's.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295103008: If our gyp does not exist, use chromium's. (Closed)

Created:
6 years, 7 months ago by scroggo

Modified:
6 years, 7 months ago

Reviewers:
hal.canary

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

If our gyp does not exist, use chromium's. The previous version had faith that if the third_party folder existed, it must contain externals/gyp. A recent change added third_party (in git, as opposed to using DEPS), so now Android has third_party but not externals/gyp. Now check the full filepath. If it's not there, back up to chromium's version. Fixes Android canary bot. TBR=halcanary@google.com Committed: http://code.google.com/p/skia/source/detail?r=14855

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	platform_tools/android/gyp_gen/android_framework_gyp.py	View		1 chunk	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/295103008/1

6 years, 7 months ago (2014-05-22 19:26:19 UTC) #2

Message was sent while issue was closed.

Change committed as 14855

Expand Messages | Collapse Messages