Issue 2951016: Switched sync protobufs to use "heavy" protobufs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2951016: Switched sync protobufs to use "heavy" protobufs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by akalin

Modified:
4 years ago

Reviewers:
ncarter

CC:
chromium-reviews, ncarter, ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, idana, Aaron Boodman, pam+watch_chromium.org, timsteele

Visibility:
Public.

Description

Switched sync protobufs to use "heavy" protobufs. This is so that unknown fields in sync proto fields are preserved. BUG=49107 TEST=compiled Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52635

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -13 lines)			Patch
M	chrome/browser/sync/protocol/autofill_specifics.proto	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/protocol/bookmark_specifics.proto	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/protocol/encryption.proto	View	1 chunk	+4 lines, -1 line	0 comments	Download
	chrome/browser/sync/protocol/extension_specifics.proto	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/protocol/nigori_specifics.proto	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/protocol/password_specifics.proto	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/protocol/preference_specifics.proto	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/protocol/sync.proto	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/protocol/sync_proto.gyp	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/protocol/theme_specifics.proto	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/protocol/typed_url_specifics.proto	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+3 lines, -1 line	0 comments	Download

Trybot results: linux mac win

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages