Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 2951016: Switched sync protobufs to use "heavy" protobufs. (Closed)

Created:
10 years, 5 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, idana, Aaron Boodman, pam+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Switched sync protobufs to use "heavy" protobufs. This is so that unknown fields in sync proto fields are preserved. BUG=49107 TEST=compiled Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -13 lines) Patch
M chrome/browser/sync/protocol/autofill_specifics.proto View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/protocol/bookmark_specifics.proto View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/protocol/encryption.proto View 1 chunk +4 lines, -1 line 0 comments Download
chrome/browser/sync/protocol/extension_specifics.proto View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/protocol/nigori_specifics.proto View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/protocol/password_specifics.proto View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/protocol/preference_specifics.proto View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/protocol/sync.proto View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/protocol/sync_proto.gyp View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/sync/protocol/theme_specifics.proto View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/protocol/typed_url_specifics.proto View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
akalin
+nick for review
10 years, 5 months ago (2010-07-14 23:39:28 UTC) #1
ncarter (slow)
10 years, 5 months ago (2010-07-14 23:48:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698