Issue 2951012: [Mac] Fix build break with r52223.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2951012: [Mac] Fix build break with r52223. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Scott Hess

Modified:
3 years, 11 months ago

Reviewers:
Mark Mentovai - out til August

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

[Mac] Fix build break with r52223. image and pboard were always initialized, but warning that they couldn't only happened on opt build, which I didn't, mea culpa... BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52232

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Trybot results:

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai - out til August

4 years, 10 months ago (2010-07-13 22:11:15 UTC) #1

Per IRC:

markmentovai: shess: lgtm
markmentovai: shess: concern about whether this does the right thing if *both*
icon an decoration are true: recommend structuring the logic with an "else if"
on one side to be explicit
markmentovai: but that's another change for another time

Expand Messages | Collapse Messages