Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/libxml/libxml.gyp

Issue 2951008: Update libxml to 2.7.7. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libxml/libxml.gyp
diff --git a/third_party/libxml/libxml.gyp b/third_party/libxml/libxml.gyp
index 8445e1aa31eb113e5c367d04a1cbc0f9d327a392..0311df1f8d83292dcb64ecfcfe61bdfd54545ef8 100644
--- a/third_party/libxml/libxml.gyp
+++ b/third_party/libxml/libxml.gyp
@@ -148,9 +148,6 @@
'xpath.c',
'xpointer.c',
],
- 'defines': [
- 'LIBXML_STATIC',
- ],
'include_dirs': [
'<(os_include)',
'<(os_include)/include',
@@ -164,9 +161,6 @@
'../icu/icu.gyp:icuuc',
],
'direct_dependent_settings': {
- 'defines': [
- 'LIBXML_STATIC',
- ],
'include_dirs': [
'<(os_include)/include',
'include',
@@ -184,6 +178,11 @@
['OS=="mac"', {'defines': ['_REENTRANT']}],
['OS=="win"', {
'product_name': 'libxml2',
+ 'defines': [
+ # This symbol prevents libxml from marking its functions with
+ # __declspec(dllexport).
+ 'LIBXML_STATIC',
+ ],
}, { # else: OS!="win"
'product_name': 'xml2',
}],

Powered by Google App Engine
This is Rietveld 408576698