Make some functions that are hit during renderer startup available for inlining

src/interpreter/bytecodes.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INTERPRETER_BYTECODES_H_
 #define V8_INTERPRETER_BYTECODES_H_
 
 #include <cstdint>
 #include <iosfwd>
 #include <string>
 
 #include "src/globals.h"
 #include "src/interpreter/bytecode-operands.h"
+#include "src/interpreter/bytecode-traits.h"

[rmcilroy, 2017/06/20 23:20:32]

I'd prefer not to expose bytecode-traits in bytecodes.h - bytecode-traits is an
icky internal file and bytecodes.h is one of the headers that is used outside of
interpreter/.  Could you instead make kOperandSizes a static const field
initialized at the top of bytecode.cc and just inline the reading of that field
here?

[hans, 2017/06/20 23:49:08]

Sounds good to me. There already is a kOperandSizes, so I called it
kOperandKindSizes.

 
 // This interface and it's implementation are independent of the
 // libv8_base library as they are used by the interpreter and the
 // standalone mkpeephole table generator program.
 
 namespace v8 {
 namespace internal {
 namespace interpreter {
 
 // The list of bytecodes which are interpreted by the interpreter.
@@ skipping 803 matching lines @@
         return 3;
       case OperandType::kRegList:
       case OperandType::kRegOutList:
         UNREACHABLE();
       default:
         return 0;
     }
     UNREACHABLE();
   }
 
-  // Returns the size of |operand| for |operand_scale|.
-  static OperandSize SizeOfOperand(OperandType operand, OperandScale scale);
+  // Returns the size of |operand_type| for |operand_scale|.
+  static OperandSize SizeOfOperand(OperandType operand_type,
+                                   OperandScale operand_scale) {
+    DCHECK_LE(operand_type, OperandType::kLast);
+    DCHECK_GE(operand_scale, OperandScale::kSingle);
+    DCHECK_LE(operand_scale, OperandScale::kLast);
+    STATIC_ASSERT(static_cast<int>(OperandScale::kQuadruple) == 4 &&
+                  OperandScale::kLast == OperandScale::kQuadruple);
+    int scale_index = static_cast<int>(operand_scale) >> 1;
+    // clang-format off
+    static const OperandSize kOperandSizes[][3] = {
+#define ENTRY(Name, ...)                                \
+    { OperandScaler<OperandType::k##Name,                 \
+                   OperandScale::kSingle>::kOperandSize,  \
+      OperandScaler<OperandType::k##Name,                 \
+                   OperandScale::kDouble>::kOperandSize,  \
+      OperandScaler<OperandType::k##Name,                 \
+                   OperandScale::kQuadruple>::kOperandSize },
+      OPERAND_TYPE_LIST(ENTRY)
+#undef ENTRY
+    };
+    // clang-format on
+    return kOperandSizes[static_cast<size_t>(operand_type)][scale_index];
+  }
 
   // Returns true if |operand_type| is a runtime-id operand (kRuntimeId).
   static bool IsRuntimeIdOperandType(OperandType operand_type);
 
   // Returns true if |operand_type| is unsigned, false if signed.
   static bool IsUnsignedOperandType(OperandType operand_type);
 
   // Returns true if a handler is generated for a bytecode at a given
   // operand scale. All bytecodes have handlers at OperandScale::kSingle,
   // but only bytecodes with scalable operands have handlers with larger
@@ skipping 45 matching lines @@
 };
 
 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os,
                                            const Bytecode& bytecode);
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_INTERPRETER_BYTECODES_H_