Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2950973002: Update dartdoc to v0.13.0+1. (Closed)

Created:
3 years, 6 months ago by jcollins
Modified:
3 years, 6 months ago
Reviewers:
devoncarew, Bill Hesse
CC:
reviews_dartlang.org, keertip
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update dartdoc to v0.13.0+1. Also update markdown. I have reviewed the changes from 0.11.2 to 0.11.3 and they LGTM. With this change, dartdoc tests should pass reliably from within the SDK. BUG= R=devoncarew@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/517b0adbaf2f3dbc08a9f34c3cf5cb7b95762cc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jcollins
Update SDK to the published dartdoc version.
3 years, 6 months ago (2017-06-20 21:13:49 UTC) #2
devoncarew
lgtm
3 years, 6 months ago (2017-06-20 21:30:36 UTC) #3
Bill Hesse
lgtm
3 years, 6 months ago (2017-06-20 21:47:14 UTC) #4
jcollins
3 years, 6 months ago (2017-06-21 14:58:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
517b0adbaf2f3dbc08a9f34c3cf5cb7b95762cc6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698