ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html - Issue 2950943002: MD Settings: Stop using IronMenuBehavior from cr-profile-avatar-selector-grid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html

Issue 2950943002: MD Settings: Stop using IronMenuBehavior from cr-profile-avatar-selector-grid. (Closed)

Patch Set: Delete commented out test. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/people_page/manage_profile.js ('K') | « ui/webui/resources/cr_elements/cr_profile_avatar_selector/compiled_resources2.gyp ('k') | ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.js » ('j') | ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector_grid.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html

diff --git a/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html b/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html

index ad15468fbcc3b1045f85951aa0afcfa91b18cfd4..3c3747bb74afe059945743f3b63fbe611d9c8585 100644

--- a/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html

+++ b/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html

@@ -1,5 +1,6 @@

-<link rel="import" href="chrome://resources/html/icon.html">

tommycli 2017/06/22 21:45:31 Is this change intentional?

dpapad 2017/06/22 23:22:48 Yes. This was discussed at https://groups.google.c

+<link rel="import" href="chrome://resources/html/icon.html">

@@ -42,12 +43,11 @@

}

</style>

<cr-profile-avatar-selector-grid id="avatar-grid"

- selected="{{selectedAvatarUrl}}" attr-for-selected="data-avatar-url"

ignore-modified-key-events="[[ignoreModifiedKeyEvents]]">

- <paper-button class="avatar" data-avatar-url$="[[item.url]]"

- title="[[item.label]]" data-is-gaia-avatar$="[[item.isGaiaAvatar]]"

- style$="background-image: [[getIconImageset_(item.url)]]">

+ <paper-button class="avatar" title="[[item.label]]"

+ style$="background-image: [[getIconImageset_(item.url)]]"

+ on-tap="onAvatarTap_">

</paper-button>

</template>

</cr-profile-avatar-selector-grid>