MD Settings: Stop using IronMenuBehavior from cr-profile-avatar-selector-grid.

chrome/browser/resources/settings/people_page/manage_profile.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-manage-profile' is the settings subpage containing controls to
  * edit a profile's name, icon, and desktop shortcut.
  */
 Polymer({
   is: 'settings-manage-profile',
 
   behaviors: [WebUIListenerBehavior, settings.RouteObserverBehavior],
 
   properties: {
     /**
-     * The currently selected profile icon URL. May be a data URL.
+     * The newly selected avatar. Populated only if the user manually changes
+     * the avatar selection. The observer ensures that the changes are
+     * propagated to the C++.
      */
-    profileIconUrl: String,
+    profileAvatar: {

[tommycli, 2017/06/22 21:45:31]

Since this property is no longer changed externally (except from a child), we
should make this profileAvatar_ so a parent never tries to bind to it.

[dpapad, 2017/06/22 23:22:48]

Done.

+      type: Object,
+      observer: 'profileAvatarChanged_',
+    },
 
     /**
      * The current profile name.
      */
     profileName: String,
 
     /**
      * True if the current profile has a shortcut.
      */
     hasProfileShortcut_: Boolean,
@@ skipping 77 matching lines @@
    * @private
    */
   onProfileNameKeydown_: function(event) {
     if (event.key == 'Escape') {
       event.target.value = this.profileName;
       event.target.blur();
     }
   },
 
   /**
-   * Handler for when an avatar is activated.
-   * @param {!Event} event
+   * Handler for when the profile avatar is changed by the user.
    * @private
    */
-  onIconActivate_: function(event) {
-    // Explicitly test against undefined, because even when an element has the
-    // data-is-gaia-avatar attribute, dataset.isGaiaAvatar returns an empty
-    // string, which is falsy.
-    var isGaiaAvatar = event.detail.item.dataset.isGaiaAvatar !== undefined;
-
-    if (isGaiaAvatar)
+  profileAvatarChanged_: function() {
+    if (this.profileAvatar.isGaiaAvatar)
       this.browserProxy_.setProfileIconToGaiaAvatar();
     else
-      this.browserProxy_.setProfileIconToDefaultAvatar(event.detail.selected);
+      this.browserProxy_.setProfileIconToDefaultAvatar(this.profileAvatar.url);
   },
 
   /**
    * @param {?settings.SyncStatus} syncStatus
    * @return {boolean} Whether the profile name field is disabled.
    * @private
    */
   isProfileNameDisabled_: function(syncStatus) {
     return !!syncStatus.supervisedUser && !syncStatus.childUser;
   },
 
   /**
    * Handler for when the profile shortcut toggle is changed.
    * @param {!Event} event
    * @private
    */
   onHasProfileShortcutChange_: function(event) {
     if (this.hasProfileShortcut_) {
       this.browserProxy_.addProfileShortcut();
     } else {
       this.browserProxy_.removeProfileShortcut();
     }
   }
 });