Issue 295093003: Revert of Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295093003: Revert of Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromi… (Closed)

Created:
6 years, 7 months ago by reed1

Modified:
6 years, 7 months ago

Reviewers:
bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert of Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromi… (https://codereview.chromium.org/291163005/) Reason for revert: broke 6 webgl/canvas tests in blink (don't know why yet) https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_7/27348/layout-test-results/results.html Original issue's description: > Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)""" > > This reverts commit 3dbceb4f8283b2fb1728d0daf010d036099a2eae. > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14806 TBR=bsalomon@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14826

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -21 lines)			Patch
M	include/core/SkPixelRef.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	include/gpu/SkGrPixelRef.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBitmap.cpp	View	4 chunks	+23 lines, -15 lines	0 comments	Download
M	src/gpu/SkGrPixelRef.cpp	View	4 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)

reed1

6 years, 7 months ago (2014-05-21 15:57:10 UTC) #1

Created Revert of Revert ""Revert of eliminate config param -- it was always
self's config (https://codereview.chromi…