Added new features tests to AppListPresenterDelegateUnittests.

ui/events/gesture_event_details.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_EVENTS_GESTURE_DETECTION_GESTURE_EVENT_DETAILS_H_
 #define UI_EVENTS_GESTURE_DETECTION_GESTURE_EVENT_DETAILS_H_
 
 #include <string.h>
 
 #include "base/logging.h"
@@ skipping 79 matching lines @@
     DCHECK_EQ(ET_GESTURE_SCROLL_UPDATE, type_);
     return data_.scroll_update.delta_units;
   }
 
   float velocity_x() const {
     DCHECK_EQ(ET_SCROLL_FLING_START, type_);
     return data_.fling_velocity.x;
   }
 
   float velocity_y() const {
-    DCHECK_EQ(ET_SCROLL_FLING_START, type_);
+    DCHECK(ET_SCROLL_FLING_START == type_ || ET_GESTURE_SCROLL_UPDATE == type_);

[sadrul, 2017/06/20 20:43:38]

Where do we set the velocity for SCROLL_UPDATE?

[newcomer, 2017/06/20 21:23:34]

It seems like it is not set:
https://cs.chromium.org/chromium/src/ui/events/gesture_event_details.cc?dr=CS...

but this code works as intended here:
https://cs.chromium.org/chromium/src/ui/app_list/views/app_list_view.cc?q=app...

So maybe it's working by accident somehow?

[sadrul, 2017/06/20 21:39:00]

I think that code wants scroll_y(), and it happens to work because data_ is a
union, and things happen to line up. You should keep the DCHECK_EQ, and update
app-list-view to use the right thing.

[newcomer, 2017/06/20 23:42:43]

Oh, interesting. Done! Thanks for your help.

     return data_.fling_velocity.y;
   }
 
   float first_finger_width() const {
     DCHECK_EQ(ET_GESTURE_TWO_FINGER_TAP, type_);
     return data_.first_finger_enclosing_rectangle.width;
   }
 
   float first_finger_height() const {
     DCHECK_EQ(ET_GESTURE_TWO_FINGER_TAP, type_);
@@ skipping 117 matching lines @@
   int touch_points_;  // Number of active touch points in the gesture.
 
   // Bounding box is an axis-aligned rectangle that contains all the
   // enclosing rectangles of the touch-points in the gesture.
   gfx::RectF bounding_box_;
 };
 
 }  // namespace ui
 
 #endif  // UI_EVENTS_GESTURE_DETECTION_GESTURE_EVENT_DETAILS_H_