chrome/browser/safe_browsing/safe_browsing_blocking_page.h - Issue 2950863002: Implement code for Start/Finish threat details collection in WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 2950863002: Implement code for Start/Finish threat details collection in WebView. (Closed)

Patch Set: fix comment Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h

index 15160c4ebdad537f6c9cda760a521b924df6e7b1..63baa9019ec17932403b503c4f65c2b2f595965d 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h

@@ -77,9 +77,6 @@ class SafeBrowsingBlockingPage : public BaseBlockingPage {

void OverrideRendererPrefs(content::RendererPreferences* prefs) override;

content::InterstitialPageDelegate::TypeID GetTypeForTesting() const override;

- // Checks the threat type to decide if we should report ThreatDetails.

- static bool ShouldReportThreatDetails(SBThreatType threat_type);

protected:

friend class SafeBrowsingBlockingPageFactoryImpl;

friend class SafeBrowsingBlockingPageTest;