Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: ios/chrome/browser/ui/payments/region_data_loader_unittest.mm

Issue 2950843002: [Payment Request] Populates region field if region code/name is valid. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/payments/region_data_loader_unittest.mm
diff --git a/ios/chrome/browser/ui/payments/region_data_loader_unittest.mm b/ios/chrome/browser/ui/payments/region_data_loader_unittest.mm
index 54e455c0818d17b1b0afcc5e24466656646b935b..de94cab3ab9d28b66ed07185e8dd1b15e1ea95a3 100644
--- a/ios/chrome/browser/ui/payments/region_data_loader_unittest.mm
+++ b/ios/chrome/browser/ui/payments/region_data_loader_unittest.mm
@@ -21,8 +21,10 @@
#endif
namespace {
-const char kQuebec[] = "QC";
-const char kOntario[] = "ON";
+const char kQuebecCode[] = "QC";
+const char kOntarioCode[] = "ON";
+const char kQuebec[] = "Quebec";
+const char kOntario[] = "Ontario";
} // namespace
class PaymentRequestRegionDataLoaderTest : public PlatformTest {
@@ -38,17 +40,18 @@ TEST_F(PaymentRequestRegionDataLoaderTest, SourceSuccess) {
// Mock the consumer.
id consumer =
[OCMockObject mockForProtocol:@protocol(RegionDataLoaderConsumer)];
- [[consumer expect] regionDataLoaderDidSucceedWithRegions:@[
- base::SysUTF8ToNSString(kQuebec), base::SysUTF8ToNSString(kOntario)
- ]];
+ [[consumer expect] regionDataLoaderDidSucceedWithRegions:@{
+ base::SysUTF8ToNSString(kQuebecCode) : base::SysUTF8ToNSString(kQuebec),
+ base::SysUTF8ToNSString(kOntarioCode) : base::SysUTF8ToNSString(kOntario)
+ }];
RegionDataLoader region_data_loader(consumer);
region_data_loader.LoadRegionData("some country",
&autofill_region_data_loader_);
std::vector<std::pair<std::string, std::string>> regions;
- regions.push_back(std::make_pair(kQuebec, "Quebec"));
- regions.push_back(std::make_pair(kOntario, "Ontario"));
+ regions.push_back(std::make_pair(kQuebecCode, kQuebec));
+ regions.push_back(std::make_pair(kOntarioCode, kOntario));
autofill_region_data_loader_.SendAsynchronousData(regions);
EXPECT_OCMOCK_VERIFY(consumer);
@@ -59,7 +62,7 @@ TEST_F(PaymentRequestRegionDataLoaderTest, SourceFailure) {
// Mock the consumer.
id consumer =
[OCMockObject mockForProtocol:@protocol(RegionDataLoaderConsumer)];
- [[consumer expect] regionDataLoaderDidSucceedWithRegions:@[]];
+ [[consumer expect] regionDataLoaderDidSucceedWithRegions:@{}];
RegionDataLoader region_data_loader(consumer);
region_data_loader.LoadRegionData("some country",

Powered by Google App Engine
This is Rietveld 408576698