[Payment Request] Populates region field if region code/name is valid.

ios/chrome/browser/ui/payments/region_data_loader.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/payments/region_data_loader.h"
 
 #include "base/strings/sys_string_conversions.h"
 #include "components/autofill/core/browser/region_data_loader.h"
 #include "ui/base/models/combobox_model.h"
 
@@ skipping 20 matching lines @@
   region_model_.LoadRegionData(country_code, autofill_region_data_loader,
                                kTimeoutInMilliseconds);
 }
 
 void RegionDataLoader::OnComboboxModelChanged(ui::ComboboxModel* model) {
   autofill::RegionComboboxModel* region_model =
       static_cast<autofill::RegionComboboxModel*>(model);
   if (region_model->IsPendingRegionDataLoad())
     return;
 
-  NSMutableArray<NSString*>* regions = [[NSMutableArray alloc] init];
+  NSMutableDictionary<NSString*, NSString*>* regions =
+      [[NSMutableDictionary alloc] init];
   if (!region_model->failed_to_load_data()) {
     for (int i = 0; i < region_model->GetItemCount(); ++i) {
-      if (!region_model->IsItemSeparatorAt(i))
-        [regions
-            addObject:base::SysUTF16ToNSString(region_model->GetItemAt(i))];
+      if (!region_model->IsItemSeparatorAt(i)) {
+        [regions setObject:base::SysUTF8ToNSString(
+                               region_model->GetRegions()[i].second)

[macourteau, 2017/06/20 16:25:00]

nit: extract |region_model->GetRegions()[i]| (or even region_model->GetRegions()
?)

[Moe, 2017/06/20 18:28:34]

Done.

+                    forKey:base::SysUTF8ToNSString(
+                               region_model->GetRegions()[i].first)];
+      }
     }
   }
   [consumer_ regionDataLoaderDidSucceedWithRegions:regions];
 }