Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2950683002: Updated tests that had incorrect annotations which were causing test failures, and updated co19 sta… (Closed)

Created:
3 years, 6 months ago by bkonyi
Modified:
3 years, 6 months ago
Reviewers:
sivachandra
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updated tests that had incorrect annotations which were causing test failures, and updated co19 status file to expect CompileTimeError for some additional tests. BUG= R=sivachandra@google.com Committed: https://github.com/dart-lang/sdk/commit/63be906fb6707e6de2ebf0ab5fe7f47baf0f8f92

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M tests/co19/co19-runtime.status View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/const_error_multiply_initialized_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/final_attempt_reinitialization_test.dart View 1 chunk +4 lines, -3 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
bkonyi
3 years, 6 months ago (2017-06-19 22:45:19 UTC) #2
bkonyi
3 years, 6 months ago (2017-06-19 22:45:21 UTC) #3
sivachandra
lgtm https://codereview.chromium.org/2950683002/diff/1/tests/language/final_attempt_reinitialization_test.dart File tests/language/final_attempt_reinitialization_test.dart (right): https://codereview.chromium.org/2950683002/diff/1/tests/language/final_attempt_reinitialization_test.dart#newcode13 tests/language/final_attempt_reinitialization_test.dart:13: : this.shopName = name; //# 02: compile-time error ...
3 years, 6 months ago (2017-06-19 22:47:48 UTC) #4
bkonyi
3 years, 6 months ago (2017-06-19 22:49:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
63be906fb6707e6de2ebf0ab5fe7f47baf0f8f92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698