Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: public/web/WebFrameClient.h

Issue 295063002: [NotLanded] Implement the fetching algorithm of the Web Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: update comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebFrameClient.h
diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h
index c61b4d17c1c07bd8c2567639cfd27aac3472c097..3f29db77058a680ac153e1267005621f838a884b 100644
--- a/public/web/WebFrameClient.h
+++ b/public/web/WebFrameClient.h
@@ -45,6 +45,8 @@
#include "public/platform/WebCommon.h"
#include "public/platform/WebFileSystem.h"
#include "public/platform/WebFileSystemType.h"
+#include "public/platform/WebManifest.h"
+#include "public/platform/WebManifestError.h"
#include "public/platform/WebStorageQuotaCallbacks.h"
#include "public/platform/WebStorageQuotaType.h"
#include "public/platform/WebURLError.h"
@@ -298,11 +300,20 @@ public:
// WARNING: This method may be called very frequently.
virtual void didUpdateCurrentHistoryItem(WebLocalFrame*) { }
+ // The frame's theme color has changed.
+ virtual void didChangeThemeColor() { }
+
+
+ // Web Manifest ---------------------------------------------------------
+
// The frame's manifest has changed.
virtual void didChangeManifest(WebLocalFrame*) { }
- // The frame's theme color has changed.
- virtual void didChangeThemeColor() { }
+ // The frame's manifest has been loaded successfully.
+ virtual void didLoadManifest(WebLocalFrame*, WebManifest) { }
Mikhail 2014/08/29 12:49:18 maybe it's worth adding the new API after the WebM
mlamouri (slow - plz ping) 2014/09/01 19:23:51 Nate already reviewed the Blink API so I would pre
+
+ // The frame's manifest loading has failed.
+ virtual void didFailLoadManifest(WebLocalFrame*, WebManifestError) { }
// Transition navigations -----------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698