Source/core/testing/URLTestHelpers.cpp - Issue 295063002: [NotLanded] Implement the fetching algorithm of the Web Manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/URLTestHelpers.cpp

Issue 295063002: [NotLanded] Implement the fetching algorithm of the Web Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/loader/ManifestLoaderTest.cpp ('K') | « Source/core/testing/DummyPageHolder.cpp ('k') | Source/modules/websockets/DOMWebSocketTest.cpp » ('j') | Source/modules/websockets/DOMWebSocketTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/testing/URLTestHelpers.cpp

diff --git a/Source/core/testing/URLTestHelpers.cpp b/Source/core/testing/URLTestHelpers.cpp

index bb67648dbf476ac0a8dd1375adb93c43c19ca839..1a0f261d8b1eb85092806f31d44bfd7c6dfd4a4a 100644

--- a/Source/core/testing/URLTestHelpers.cpp

+++ b/Source/core/testing/URLTestHelpers.cpp

@@ -53,8 +53,7 @@ void registerMockedURLLoad(const WebURL& fullURL, const WebString& fileName, con

void registerMockedURLLoad(const WebURL& fullURL, const WebString& fileName, const WebString& relativeBaseDirectory, const WebString& mimeType)

{

- WebURLResponse response;

- response.initialize();

+ WebURLResponse response(fullURL);

Mikhail 2014/08/29 12:49:18 is this change Manifest-related?

mlamouri (slow - plz ping) 2014/09/01 19:23:50 It's needed for the cors check. It was part of htt

response.setMIMEType(mimeType);

response.setHTTPStatusCode(200);