Source/core/loader/FrameLoaderClient.h - Issue 295063002: [NotLanded] Implement the fetching algorithm of the Web Manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoaderClient.h

Issue 295063002: [NotLanded] Implement the fetching algorithm of the Web Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/FrameLoaderClient.h

diff --git a/Source/core/loader/FrameLoaderClient.h b/Source/core/loader/FrameLoaderClient.h

index a8a1fef7c734a14be7bbf36f5a1027561ee3ee9a..63a5512626c7b97d7bf43c10821c749cb7711b30 100644

--- a/Source/core/loader/FrameLoaderClient.h

+++ b/Source/core/loader/FrameLoaderClient.h

@@ -36,6 +36,8 @@

#include "core/loader/NavigationPolicy.h"

#include "platform/network/ResourceLoadPriority.h"

#include "platform/weborigin/Referrer.h"

+#include "public/platform/WebManifest.h"

+#include "public/platform/WebManifestError.h"

#include "wtf/Forward.h"

#include "wtf/Vector.h"

#include <v8.h>

@@ -228,6 +230,8 @@ namespace blink {

virtual void didStopAllLoaders() { }

virtual void dispatchDidChangeManifest() { }

+ virtual void dispatchDidLoadManifest(blink::WebManifest) { }

dcheng 2014/08/27 00:13:16 Do we really want to pass by value here?

mlamouri (slow - plz ping) 2014/09/01 19:23:50 Done.

+ virtual void dispatchDidFailLoadManifest(blink::WebManifestError) { }

virtual bool isFrameLoaderClientImpl() const { return false; }

};

« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/loader/ManifestLoader.h » ('j') | Source/core/loader/ManifestLoader.cpp » ('J')