Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: Source/core/fetch/ResourceFetcher.cpp

Issue 295063002: [NotLanded] Implement the fetching algorithm of the Web Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/fetch/ResourceFetcher.cpp
diff --git a/Source/core/fetch/ResourceFetcher.cpp b/Source/core/fetch/ResourceFetcher.cpp
index f2a2eb2c92c6d238432b5a5f95994d5a5b77db8f..6ec02ce9c403f78b2fe98a81ad9b438711c8c7e6 100644
--- a/Source/core/fetch/ResourceFetcher.cpp
+++ b/Source/core/fetch/ResourceFetcher.cpp
@@ -90,17 +90,16 @@ static Resource* createResource(Resource::Type type, const ResourceRequest& requ
case Resource::Raw:
case Resource::TextTrack:
case Resource::Media:
+ case Resource::ImportResource:
return new RawResource(request, type);
case Resource::XSLStyleSheet:
return new XSLStyleSheetResource(request);
case Resource::LinkPrefetch:
- return new Resource(request, Resource::LinkPrefetch);
case Resource::LinkSubresource:
- return new Resource(request, Resource::LinkSubresource);
+ case Resource::Manifest:
+ return new Resource(request, type);
case Resource::Shader:
return new ShaderResource(request);
- case Resource::ImportResource:
- return new RawResource(request, type);
}
ASSERT_NOT_REACHED();
@@ -122,6 +121,7 @@ static ResourceLoadPriority loadPriority(Resource::Type type, const FetchRequest
case Resource::Script:
case Resource::Font:
case Resource::ImportResource:
+ case Resource::Manifest:
return ResourceLoadPriorityMedium;
case Resource::Image:
// We'll default images to VeryLow, and promote whatever is visible. This improves
@@ -210,6 +210,7 @@ static ResourceRequest::TargetType requestTargetType(const ResourceFetcher* fetc
case Resource::Shader:
case Resource::Raw:
case Resource::ImportResource:
+ case Resource::Manifest:
return ResourceRequest::TargetIsSubresource;
case Resource::LinkPrefetch:
return ResourceRequest::TargetIsPrefetch;
@@ -400,6 +401,11 @@ ResourcePtr<RawResource> ResourceFetcher::fetchTextTrack(FetchRequest& request)
return toRawResource(requestResource(Resource::TextTrack, request));
}
+ResourcePtr<Resource> ResourceFetcher::fetchManifest(FetchRequest& request)
+{
+ return requestResource(Resource::Manifest, request);
+}
+
void ResourceFetcher::preCacheSubstituteDataForMainResource(const FetchRequest& request, const SubstituteData& substituteData)
{
const KURL& url = request.url();
@@ -446,6 +452,7 @@ bool ResourceFetcher::checkInsecureContent(Resource::Type type, const KURL& url,
case Resource::MainResource:
case Resource::LinkPrefetch:
case Resource::LinkSubresource:
+ case Resource::Manifest:
// These cannot affect the current document.
treatment = TreatAsAlwaysAllowedContent;
break;
@@ -503,6 +510,7 @@ bool ResourceFetcher::canRequest(Resource::Type type, const KURL& url, const Res
case Resource::Shader:
case Resource::ImportResource:
case Resource::Media:
+ case Resource::Manifest:
// By default these types of resources can be loaded from any origin.
// FIXME: Are we sure about Resource::Font?
if (originRestriction == FetchRequest::RestrictToSameOrigin && !securityOrigin->canRequest(url)) {
@@ -563,6 +571,7 @@ bool ResourceFetcher::canRequest(Resource::Type type, const KURL& url, const Res
case Resource::Raw:
case Resource::LinkPrefetch:
case Resource::LinkSubresource:
+ case Resource::Manifest:
break;
case Resource::Media:
case Resource::TextTrack:

Powered by Google App Engine
This is Rietveld 408576698