Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 295053002: Intent to Ship: CSS Shapes Module Level 1 (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use unprefixed versions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/nonstable-css-properties-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
rwlbuis
PTAL, should be green now, and we have the 3x LGTM! :)
6 years, 7 months ago (2014-05-20 22:15:36 UTC) #1
rwlbuis
Oops, actually publish.
6 years, 7 months ago (2014-05-20 22:20:49 UTC) #2
rwlbuis
Adding more candidates as Levi probably is not an API owner for this.
6 years, 7 months ago (2014-05-23 19:05:49 UTC) #3
eseidel
lgtm
6 years, 7 months ago (2014-05-23 19:16:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/295053002/40001
6 years, 7 months ago (2014-05-23 19:17:24 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 20:36:12 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 21:56:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/8992)
6 years, 7 months ago (2014-05-23 21:56:26 UTC) #8
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-05-23 23:18:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/295053002/40001
6 years, 7 months ago (2014-05-23 23:19:19 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 00:55:16 UTC) #11
Message was sent while issue was closed.
Change committed as 174736

Powered by Google App Engine
This is Rietveld 408576698