Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Issue 2950493002: Add closure_test (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add closure_test - currently only for AST-based elements; IR-based to come R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/4a31a0be4762edc6645c0a77a3294eada5c29e63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -529 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +3 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/closure/closure_test.dart View 1 chunk +60 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/closure/data/parameter_in_try.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A + tests/compiler/dart2js/equivalence/id_equivalence.dart View 6 chunks +30 lines, -15 lines 0 comments Download
A + tests/compiler/dart2js/equivalence/id_equivalence_helper.dart View 6 chunks +38 lines, -46 lines 0 comments Download
A + tests/compiler/dart2js/equivalence/id_equivalence_test.dart View 1 chunk +15 lines, -8 lines 0 comments Download
D tests/compiler/dart2js/inference/enumerator.dart View 1 chunk +0 lines, -237 lines 0 comments Download
D tests/compiler/dart2js/inference/id_equivalence_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 2 chunks +18 lines, -149 lines 0 comments Download
M tests/compiler/dart2js/inference/send_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-19 12:42:44 UTC) #2
Emily Fortuna
lgtm!! Exciting!
3 years, 6 months ago (2017-06-19 17:58:13 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-20 10:27:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4a31a0be4762edc6645c0a77a3294eada5c29e63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698