Changing target_arch selection in nacl to match chrome....

Changing target_arch selection in nacl to match chrome.
This doesn't resolve the variable application order,
but it should fix the current bad behavior.

BUG=None
TEST=None



Committed: http://code.google.com/p/nativeclient/source/detail?r=890

[gregoryd, 2009-10-21 20:15:07]

Are there plans to provide better support for this? Can gyp define a
'build_arch' variable?

http://codereview.chromium.org/295044/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/295044/diff/1/2#newcode64
Line 64: '<!(uname -m | sed -e "s/i.86/ia32/;s/x86_64/x64/;s/arm.*/arm/")'
Will it still work with GYP_DEFINES? I think it's required to build arm binaries
on Linux.

http://codereview.chromium.org/295044/diff/1/2#newcode70
Line 70: 'target_arch%': '<(target_arch)',
gyp question: when <(target_arch) is referred below, which one will be used?

[bradn, 2009-10-21 20:23:50]

I generally agree with the idea that this should be available as a built-in gyp
variable, but I think deciding what that would look like (and still allowing
overide) will take some time to decide. This was intended to fix the immediate
issue.

sgk and I are planning to convene a gyp meeting in the next ~week to talk about
a number of long standing issue, variables with likely come up extensively.

http://codereview.chromium.org/295044/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/295044/diff/1/2#newcode64
Line 64: '<!(uname -m | sed -e "s/i.86/ia32/;s/x86_64/x64/;s/arm.*/arm/")'
On 2009/10/21 20:15:07, gregoryd wrote:
> Will it still work with GYP_DEFINES? I think it's required to build arm
binaries
> on Linux.

Yes it will still work with GYP_DEFINES.

http://codereview.chromium.org/295044/diff/1/2#newcode70
Line 70: 'target_arch%': '<(target_arch)',
On 2009/10/21 20:15:07, gregoryd wrote:
> gyp question: when <(target_arch) is referred below, which one will be used?
> 

This will use the one from the variables section above, unless overidden with
GYP_DEFINES.

[gregoryd, 2009-10-21 20:28:01]

LGTM