Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 295043002: Add RSA-OAEP support from upstream NSS bugs 1009794 and 1009785 (Closed)

Created:
6 years, 7 months ago by Ryan Sleevi
Modified:
6 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews
Visibility:
Public.

Description

Add RSA-OAEP support from upstream NSS bugs 1009794 and 1009785 BUG=372917 R=wtc

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+540 lines, -62 lines) Patch
M README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
M nss/exports_win.def View 1 chunk +2 lines, -0 lines 0 comments Download
M nss/lib/pk11wrap/pk11obj.c View 5 chunks +78 lines, -35 lines 2 comments Download
M nss/lib/pk11wrap/pk11pub.h View 1 chunk +29 lines, -9 lines 0 comments Download
M nss/lib/softoken/pkcs11.c View 1 chunk +2 lines, -0 lines 0 comments Download
M nss/lib/softoken/pkcs11c.c View 7 chunks +48 lines, -18 lines 0 comments Download
A patches/nss-rsa-oaep.patch View 1 chunk +377 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
wtc: PTAL. Just the two upstream patches from me (as checked in) and your const-correctness ...
6 years, 7 months ago (2014-05-20 19:02:25 UTC) #1
wtc
Patch set 1 LGTM. https://codereview.chromium.org/295043002/diff/1/nss/lib/pk11wrap/pk11obj.c File nss/lib/pk11wrap/pk11obj.c (right): https://codereview.chromium.org/295043002/diff/1/nss/lib/pk11wrap/pk11obj.c#newcode1067 nss/lib/pk11wrap/pk11obj.c:1067: if (!key || key->keyType != ...
6 years, 7 months ago (2014-05-20 19:25:57 UTC) #2
Ryan Sleevi
https://codereview.chromium.org/295043002/diff/1/nss/lib/pk11wrap/pk11obj.c File nss/lib/pk11wrap/pk11obj.c (right): https://codereview.chromium.org/295043002/diff/1/nss/lib/pk11wrap/pk11obj.c#newcode1067 nss/lib/pk11wrap/pk11obj.c:1067: if (!key || key->keyType != rsaKey) { On 2014/05/20 ...
6 years, 7 months ago (2014-05-20 21:19:14 UTC) #3
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 7 months ago (2014-05-20 21:38:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/295043002/1
6 years, 7 months ago (2014-05-20 21:39:09 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 21:39:36 UTC) #6
Message was sent while issue was closed.
Change committed as 271760

Powered by Google App Engine
This is Rietveld 408576698