Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2950413002: Added timeout parameter to RawSecureSocket and SecureSocket connect methods. Also updated CHANGELOG… (Closed)

Created:
3 years, 6 months ago by bkonyi
Modified:
3 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added timeout parameter to RawSecureSocket and SecureSocket connect methods. Also updated CHANGELOG and SecureSocket tests to reflect this change. Issue 19120. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/06456e83d8b59349914fa222a673f66ad10a5549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -5 lines 0 comments Download
M sdk/lib/io/secure_socket.dart View 2 chunks +14 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 6 months ago (2017-06-22 20:19:25 UTC) #2
zra
lgtm
3 years, 6 months ago (2017-06-22 20:43:42 UTC) #3
bkonyi
3 years, 6 months ago (2017-06-22 20:45:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06456e83d8b59349914fa222a673f66ad10a5549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698