Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3926)

Unified Diff: chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm

Issue 2950403002: [Mac] Add system share menu
Patch Set: CL comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm
index 9191a67d2b12258329a094ca301ed0f14afd456e..82e51affd79f92b830136b3ceac759f2661416b6 100644
--- a/chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm
+++ b/chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm
@@ -7,9 +7,11 @@
#include "base/logging.h"
#include "chrome/app/chrome_command_ids.h"
#import "chrome/browser/ui/cocoa/accelerators_cocoa.h"
+#include "chrome/grit/generated_resources.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "testing/gtest_mac.h"
#include "ui/base/accelerators/platform_accelerator_cocoa.h"
+#include "ui/base/l10n/l10n_util_mac.h"
#import "ui/events/keycodes/keyboard_code_conversion_mac.h"
typedef InProcessBrowserTest AcceleratorsCocoaBrowserTest;
@@ -112,6 +114,13 @@ IN_PROC_BROWSER_TEST_F(AcceleratorsCocoaBrowserTest,
IN_PROC_BROWSER_TEST_F(AcceleratorsCocoaBrowserTest,
MappingAcceleratorsInMainMenu) {
AcceleratorsCocoa* keymap = AcceleratorsCocoa::GetInstance();
+ // The "Share" menu is dynamically populated.
+ NSMenu* mainMenu = [NSApp mainMenu];
+ NSMenu* fileMenu = [[mainMenu itemWithTag:IDC_FILE_MENU] submenu];
+ NSMenu* shareMenu =
+ [[fileMenu itemWithTitle:l10n_util::GetNSString(IDS_SHARE_MAC)] submenu];
+ [[shareMenu delegate] menuNeedsUpdate:shareMenu];
+
for (AcceleratorsCocoa::AcceleratorMap::iterator it =
keymap->accelerators_.begin();
it != keymap->accelerators_.end();

Powered by Google App Engine
This is Rietveld 408576698