[Extensions Bindings] Check availability of custom API properties

extensions/renderer/bindings/api_binding_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/stl_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "extensions/renderer/bindings/api_binding.h"
@@ skipping 588 matching lines @@
 TEST_F(APIBindingUnittest, TestProperties) {
   SetProperties(
       "{"
       "  'prop1': { 'value': 17, 'type': 'integer' },"
       "  'prop2': {"
       "    'type': 'object',"
       "    'properties': {"
       "      'subprop1': { 'value': 'some value', 'type': 'string' },"
       "      'subprop2': { 'value': true, 'type': 'boolean' }"
       "    }"
+      "  },"
+      "  'linuxOnly': {"
+      "    'value': 'linux',"
+      "    'type': 'string',"
+      "    'platforms': ['linux']"
+      "  },"
+      "  'nonLinuxOnly': {"
+      "    'value': 'nonlinux',"
+      "    'type': 'string',"
+      "    'platforms': ['win', 'mac', 'chromeos']"
       "  }"
       "}");
   InitializeBinding();
 
   v8::HandleScope handle_scope(isolate());
   v8::Local<v8::Context> context = MainContext();
   v8::Local<v8::Object> binding_object = binding()->CreateInstance(context);
   EXPECT_EQ("17",
             GetStringPropertyFromObject(binding_object, context, "prop1"));
   EXPECT_EQ(R"({"subprop1":"some value","subprop2":true})",
             GetStringPropertyFromObject(binding_object, context, "prop2"));
+
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
+  EXPECT_EQ("\"linux\"",
+            GetStringPropertyFromObject(binding_object, context, "linuxOnly"));
+  EXPECT_EQ("undefined", GetStringPropertyFromObject(binding_object, context,
+                                                     "nonLinuxOnly"));
+#else
+  EXPECT_EQ("undefined",
+            GetStringPropertyFromObject(binding_object, context, "linuxOnly"));
+  EXPECT_EQ("nonlinux", GetStringPropertyFromObject(binding_object, context,

[jbroman, 2017/06/29 15:24:21]

As the trybots are already indicating, this should be "\"nonlinux\"".

[Devlin, 2017/06/29 21:00:51]

Yep, already done in PS4 :)

+                                                    "nonLinuxOnly"));
+#endif
 }
 
 TEST_F(APIBindingUnittest, TestRefProperties) {
   SetProperties(
       "{"
       "  'alpha': {"
       "    '$ref': 'AlphaRef',"
       "    'value': ['a']"
       "  },"
       "  'beta': {"
@@ skipping 643 matching lines @@
 
   // The extra property should be present on the binding object.
   EXPECT_EQ("42", GetStringPropertyFromObject(binding_object, context,
                                               "hookedProperty"));
   // Sanity check: other values should still be there.
   EXPECT_EQ("function",
             GetStringPropertyFromObject(binding_object, context, "oneString"));
 }
 
 }  // namespace extensions