Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc

Issue 2950313002: Enable large-scale FEC tests on iOS. (Closed)
Patch Set: Enable tests. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
diff --git a/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc b/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
index c698d676ecf5ae1e556102504d4dfe14bc906f54..cc6512d7d4c2f1ff1f127e35b8ec1656ac20ae5f 100644
--- a/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
+++ b/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
@@ -108,8 +108,8 @@ void RunTest(bool use_flexfec) {
ForwardErrorCorrection::RecoveredPacketList recovered_packet_list;
std::list<uint8_t*> fec_mask_list;
- // Running over only one loss rate to limit execution time.
- const float loss_rate[] = {0.5f};
+ // Running over only two loss rates to limit execution time.
+ const float loss_rate[] = {0.05f, 0.01f};
const uint32_t loss_rate_size = sizeof(loss_rate) / sizeof(*loss_rate);
const float reorder_rate = 0.1f;
const float duplicate_rate = 0.1f;
@@ -463,19 +463,11 @@ void RunTest(bool use_flexfec) {
<< "Recovered packet list is not empty";
}
-// Too slow to finish before timeout on iOS. See webrtc:4755.
-#if defined(WEBRTC_IOS)
-#define MAYBE_UlpfecTest DISABLED_UlpfecTest
-#define MAYBE_FlexfecTest DISABLED_FlexfecTest
-#else
-#define MAYBE_UlpfecTest UlpfecTest
-#define MAYBE_FlexfecTest FlexfecTest
-#endif
-TEST(FecTest, MAYBE_UlpfecTest) {
+TEST(FecTest, UlpfecTest) {
RunTest(false);
}
-TEST(FecTest, MAYBE_FlexfecTest) {
+TEST(FecTest, FlexfecTest) {
RunTest(true);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698