Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 2950303002: Handle for-loop with simple break in compile_from_dill_test (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/elements/modelx.dart
diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart
index 7d2258dd8042219d214961904a0ed3eb85bee675..1bc21b84ed7fd168b35dc9d3e152d7121794b56a 100644
--- a/pkg/compiler/lib/src/elements/modelx.dart
+++ b/pkg/compiler/lib/src/elements/modelx.dart
@@ -3337,7 +3337,7 @@ class UnnamedMixinApplicationElementX extends MixinApplicationElementX {
bool get isAbstract => true;
}
-class LabelDefinitionX implements LabelDefinition<Node> {
+class LabelDefinitionX extends LabelDefinition<Node> {
final Label label;
final String labelName;
final JumpTargetX target;
@@ -3362,12 +3362,10 @@ class LabelDefinitionX implements LabelDefinition<Node> {
target.isContinueTarget = true;
}
- bool get isTarget => isBreakTarget || isContinueTarget;
-
String toString() => 'Label:${name}';
}
-class JumpTargetX implements JumpTarget<Node> {
+class JumpTargetX extends JumpTarget<Node> {
final ExecutableElement executableContext;
final Node statement;
final int nestingLevel;
@@ -3382,10 +3380,6 @@ class JumpTargetX implements JumpTarget<Node> {
@override
MemberElement get memberContext => executableContext.memberContext;
- String get name => "target";
-
- bool get isTarget => isBreakTarget || isContinueTarget;
-
LabelDefinition<Node> addLabel(Label label, String labelName,
{bool isBreakTarget: false}) {
LabelDefinitionX result = new LabelDefinitionX(label, labelName, this);

Powered by Google App Engine
This is Rietveld 408576698