Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Issue 2950273002: Make VisiblePosition::AfterNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-22T17:02:21 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisiblePosition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
index 2f2866dc3c0eb5f273f4f6e84882d4ecd34a4fa3..eb00000a420fdb9606989cb27239323de19149a1 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
@@ -131,9 +131,9 @@ TEST_F(EditingUtilitiesTest, tableElementJustBefore) {
Node* host = GetDocument().getElementById("host");
Node* table = GetDocument().getElementById("table");
- EXPECT_EQ(table, TableElementJustBefore(VisiblePosition::AfterNode(table)));
+ EXPECT_EQ(table, TableElementJustBefore(VisiblePosition::AfterNode(*table)));
EXPECT_EQ(table, TableElementJustBefore(
- VisiblePositionInFlatTree::AfterNode(table)));
+ VisiblePositionInFlatTree::AfterNode(*table)));
EXPECT_EQ(table,
TableElementJustBefore(VisiblePosition::LastPositionInNode(table)));
@@ -145,9 +145,9 @@ TEST_F(EditingUtilitiesTest, tableElementJustBefore) {
EXPECT_EQ(table, TableElementJustBefore(
CreateVisiblePosition(PositionInFlatTree(host, 2))));
- EXPECT_EQ(nullptr, TableElementJustBefore(VisiblePosition::AfterNode(host)));
- EXPECT_EQ(nullptr,
- TableElementJustBefore(VisiblePositionInFlatTree::AfterNode(host)));
+ EXPECT_EQ(nullptr, TableElementJustBefore(VisiblePosition::AfterNode(*host)));
+ EXPECT_EQ(nullptr, TableElementJustBefore(
+ VisiblePositionInFlatTree::AfterNode(*host)));
EXPECT_EQ(nullptr,
TableElementJustBefore(VisiblePosition::LastPositionInNode(host)));
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisiblePosition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698