Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1608)

Unified Diff: extensions/common/permissions/extensions_api_permissions.cc

Issue 2950203002: Add new permission string for extensions that override new tab pages. (Closed)
Patch Set: Devlin feedback. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/extensions_api_permissions.cc
diff --git a/extensions/common/permissions/extensions_api_permissions.cc b/extensions/common/permissions/extensions_api_permissions.cc
index e9eba1986fb51c3171f8858fc6b047e77e29edb7..05910ffff36008f6d07fdd169dd81332fa0324c0 100644
--- a/extensions/common/permissions/extensions_api_permissions.cc
+++ b/extensions/common/permissions/extensions_api_permissions.cc
@@ -31,7 +31,7 @@ std::vector<std::unique_ptr<APIPermissionInfo>>
ExtensionsAPIPermissions::GetAllPermissions() const {
// WARNING: If you are modifying a permission message in this list, be sure to
// add the corresponding permission message rule to
- // ChromePermissionMessageProvider::GetPermissionMessages as well.
+ // ChromePermissionMessageRule::GetAllRules as well.
APIPermissionInfo::InitInfo permissions_to_register[] = {
{APIPermission::kAlarms, "alarms"},
{APIPermission::kAlphaEnabled, "app.window.alpha"},
@@ -71,6 +71,8 @@ ExtensionsAPIPermissions::GetAllPermissions() const {
{APIPermission::kNetworkingOnc, "networking.onc"},
{APIPermission::kNetworkingPrivate, "networkingPrivate",
APIPermissionInfo::kFlagCannotBeOptional},
+ {APIPermission::kNewTabPageOverride, "newTabPageOverride",
+ APIPermissionInfo::kFlagCannotBeOptional},
{APIPermission::kPower, "power"},
{APIPermission::kPrinterProvider, "printerProvider"},
{APIPermission::kSerial, "serial"},

Powered by Google App Engine
This is Rietveld 408576698