Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2950193002: Clean up duplicate type inference code for fetching parameter types. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up duplicate type inference code for fetching parameter types. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/945540c8bbfaff2776982b5e3ddb67d12dfec664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -26 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-21 21:28:33 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-21 21:48:36 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-21 21:57:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
945540c8bbfaff2776982b5e3ddb67d12dfec664 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698