color: Use ICCProfile from display::Display instead of FromBestMonitor

content/browser/web_contents/web_contents_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_view_aura.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/auto_reset.h"
@@ skipping 693 matching lines @@
   display::Screen* screen = display::Screen::GetScreen();
   const display::Display display = window
                                        ? screen->GetDisplayNearestWindow(window)
                                        : screen->GetPrimaryDisplay();
   results->rect = display.bounds();
   results->available_rect = display.work_area();
   results->depth = display.color_depth();
   results->depth_per_component = display.depth_per_component();
   results->is_monochrome = display.is_monochrome();
   results->device_scale_factor = display.device_scale_factor();
-  results->icc_profile = gfx::ICCProfile::FromBestMonitor();
-  if (!results->icc_profile.IsValid())
-    gfx::ColorSpace::CreateSRGB().GetICCProfile(&results->icc_profile);
-  DCHECK(results->icc_profile.IsValid());
+  display.color_space().GetICCProfile(&results->icc_profile);

[hubbe, 2017/06/23 21:31:52]

seems this would be easier to read if said something like:
  results->icc_profile = display.color_space().GetICCProfile();

What do we do if/when the color space can't be represented as an ICC profile?

[ccameron, 2017/06/23 22:44:10]

I didn't change this instance because it affects IPCs and starts getting into
Blink (so the scope grows). My next patch in this sequence changes ScreenInfo to
have a gfx::ColorSpace instead of ICCProfile.

 
   // The Display rotation and the ScreenInfo orientation are not the same
   // angle. The former is the physical display rotation while the later is the
   // rotation required by the content to be shown properly on the screen, in
   // other words, relative to the physical display.
   results->orientation_angle = display.RotationAsDegree();
   if (results->orientation_angle == 90)
     results->orientation_angle = 270;
   else if (results->orientation_angle == 270)
     results->orientation_angle = 90;
@@ skipping 617 matching lines @@
                                         bool allow_multiple_selection) {
   NOTIMPLEMENTED() << " show " << items.size() << " menu items";
 }
 
 void WebContentsViewAura::HidePopupMenu() {
   NOTIMPLEMENTED();
 }
 #endif
 
 }  // namespace content