color: Use ICCProfile from display::Display instead of FromBestMonitor

cc/surfaces/surface_aggregator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/surface_aggregator.h"
 
 #include <stddef.h>
 
 #include <map>
 
@@ skipping 920 matching lines @@
   auto it = previous_contained_surfaces_.find(surface_id);
   if (it == previous_contained_surfaces_.end())
     return;
   // Set the last drawn index as 0 to ensure full damage next time it's drawn.
   it->second = 0;
 }
 
 void SurfaceAggregator::SetOutputColorSpace(
     const gfx::ColorSpace& blending_color_space,
     const gfx::ColorSpace& output_color_space) {
-  blending_color_space_ = blending_color_space;
-  output_color_space_ = output_color_space;
+  blending_color_space_ = blending_color_space.IsValid()

[hubbe, 2017/06/23 21:31:52]

Can we just DCHECK() instead?

[ccameron, 2017/06/23 22:44:10]

There's the question: "Suppose we can't parse a display's ICC profile. At what
point do we compensate for that?".

For the moment, this is the choke point that all paths go through.

Once we get a bit more cleanup in place, I'd like to add DCHECKs here, and
remove the validation. But first we'll need to clean up the platform-specific
color profile code.

+                              ? blending_color_space
+                              : gfx::ColorSpace::CreateSRGB();
+  output_color_space_ = output_color_space.IsValid()
+                            ? output_color_space
+                            : gfx::ColorSpace::CreateSRGB();
 }
 
 }  // namespace cc