Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2950173004: Fix compiler==none case in browser testing (Dartium case) (Closed)

Created:
3 years, 6 months ago by Bill Hesse
Modified:
3 years, 6 months ago
Reviewers:
Bob Nystrom, kustermann
CC:
reviews_dartlang.org, Bob Nystrom
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix compiler==none case in browser testing (Dartium case) Error was introduced in https://codereview.chromium.org/2947473002/ BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/d8ec6450d0e40c9dcdbf7826887418a7ff120d83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/testing/dart/test_suite.dart View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
3 years, 6 months ago (2017-06-22 09:27:49 UTC) #2
kustermann
lgtm
3 years, 6 months ago (2017-06-22 09:30:09 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as d8ec6450d0e40c9dcdbf7826887418a7ff120d83 (presubmit successful).
3 years, 6 months ago (2017-06-22 09:30:30 UTC) #5
Bob Nystrom
3 years, 6 months ago (2017-06-22 16:09:07 UTC) #7
Message was sent while issue was closed.
Sorry about that. Thanks for the fix!

Powered by Google App Engine
This is Rietveld 408576698