Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: net/test/spawned_test_server/local_test_server_win.cc

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/spawned_test_server/local_test_server_win.cc
diff --git a/net/test/spawned_test_server/local_test_server_win.cc b/net/test/spawned_test_server/local_test_server_win.cc
index 65d554eba25e021cf2fe74817b78b3d90c86e8f5..e2780e7fbb9a1a6fc5065151febded0c832fc519 100644
--- a/net/test/spawned_test_server/local_test_server_win.cc
+++ b/net/test/spawned_test_server/local_test_server_win.cc
@@ -125,7 +125,8 @@ bool LocalTestServer::LaunchPython(const base::FilePath& testserver_path) {
base::IntToString(reinterpret_cast<uintptr_t>(child_write)));
base::LaunchOptions launch_options;
- launch_options.inherit_handles = true;
+ // TODO(brettw) bug 748258: Share only explicit handles.
+ launch_options.inherit_mode = base::LaunchOptions::Inherit::kAll;
process_ = base::LaunchProcess(python_command, launch_options);
if (!process_.IsValid()) {
LOG(ERROR) << "Failed to launch " << python_command.GetCommandLineString();
« no previous file with comments | « net/test/spawned_test_server/local_test_server_posix.cc ('k') | sandbox/linux/services/namespace_sandbox_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698