Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: content/browser/posix_file_descriptor_info_impl_unittest.cc

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/posix_file_descriptor_info_impl_unittest.cc
diff --git a/content/browser/file_descriptor_info_impl_unittest.cc b/content/browser/posix_file_descriptor_info_impl_unittest.cc
similarity index 72%
rename from content/browser/file_descriptor_info_impl_unittest.cc
rename to content/browser/posix_file_descriptor_info_impl_unittest.cc
index 1d442f796820f283f47f83ac9c134c68f0e14bbe..6f4903dacbc94bb15be2b6d1f9e91cf285b529b3 100644
--- a/content/browser/file_descriptor_info_impl_unittest.cc
+++ b/content/browser/posix_file_descriptor_info_impl_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "content/browser/file_descriptor_info_impl.h"
+#include "content/browser/posix_file_descriptor_info_impl.h"
#include <fcntl.h>
#include <unistd.h>
@@ -35,11 +35,12 @@ bool VerifyClosed(int fd) {
namespace content {
-typedef testing::Test FileDescriptorInfoTest;
+typedef testing::Test PosixFileDescriptorInfoTest;
-TEST_F(FileDescriptorInfoTest, Transfer) {
+TEST_F(PosixFileDescriptorInfoTest, Transfer) {
int testingId = 42;
- std::unique_ptr<FileDescriptorInfo> target(FileDescriptorInfoImpl::Create());
+ std::unique_ptr<PosixFileDescriptorInfo> target(
+ PosixFileDescriptorInfoImpl::Create());
base::ScopedFD fd(GetSafeFd());
int raw_fd = fd.get();
@@ -53,9 +54,10 @@ TEST_F(FileDescriptorInfoTest, Transfer) {
ASSERT_TRUE(VerifyClosed(raw_fd));
}
-TEST_F(FileDescriptorInfoTest, Share) {
+TEST_F(PosixFileDescriptorInfoTest, Share) {
int testingId = 42;
- std::unique_ptr<FileDescriptorInfo> target(FileDescriptorInfoImpl::Create());
+ std::unique_ptr<PosixFileDescriptorInfo> target(
+ PosixFileDescriptorInfoImpl::Create());
base::ScopedFD fd(GetSafeFd());
int raw_fd = fd.get();
@@ -69,18 +71,19 @@ TEST_F(FileDescriptorInfoTest, Share) {
ASSERT_TRUE(!VerifyClosed(fd.release()));
}
-TEST_F(FileDescriptorInfoTest, GetMappingWithIDAdjustment) {
+TEST_F(PosixFileDescriptorInfoTest, GetMappingWithIDAdjustment) {
int testingId1 = 42;
int testingId2 = 43;
- std::unique_ptr<FileDescriptorInfo> target(FileDescriptorInfoImpl::Create());
+ std::unique_ptr<PosixFileDescriptorInfo> target(
+ PosixFileDescriptorInfoImpl::Create());
target->Transfer(testingId1, base::ScopedFD(GetSafeFd()));
target->Transfer(testingId2, base::ScopedFD(GetSafeFd()));
- std::unique_ptr<base::FileHandleMappingVector> mapping =
+ base::FileHandleMappingVector mapping =
target->GetMappingWithIDAdjustment(100);
- ASSERT_EQ((*mapping)[0].second, 142);
- ASSERT_EQ((*mapping)[1].second, 143);
+ ASSERT_EQ(mapping[0].second, 142);
+ ASSERT_EQ(mapping[1].second, 143);
}
} // namespace content
« no previous file with comments | « content/browser/posix_file_descriptor_info_impl.cc ('k') | content/browser/zygote_host/zygote_communication_linux.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698