Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: components/browser_watcher/window_hang_monitor_win_unittest.cc

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/window_hang_monitor_win_unittest.cc
diff --git a/components/browser_watcher/window_hang_monitor_win_unittest.cc b/components/browser_watcher/window_hang_monitor_win_unittest.cc
index 2df2a7b5a1c6d970ca48d8d75a083eb375ae84a2..e5a31bf2fe2da6f259d630f1f7ab5bc920419b14 100644
--- a/components/browser_watcher/window_hang_monitor_win_unittest.cc
+++ b/components/browser_watcher/window_hang_monitor_win_unittest.cc
@@ -362,7 +362,8 @@ class WindowHangMonitorTest : public testing::Test {
AppendSwitchHandle(&command_line, kChildWritePipeSwitch, child_write_pipe);
base::LaunchOptions options = {};
- options.inherit_handles = true;
+ // TODO(brettw) bug 748258: Share only explicit handles.
+ options.inherit_mode = base::LaunchOptions::Inherit::kAll;
monitored_process_ = base::LaunchProcess(command_line, options);
if (!monitored_process_.IsValid())
return false;
« no previous file with comments | « components/browser_watcher/watcher_client_win.cc ('k') | components/crash/content/browser/crash_dump_manager_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698