Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: components/arc/crash_collector/arc_crash_collector_bridge.cc

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/process_proxy/process_proxy.cc ('k') | components/browser_watcher/watcher_client_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/crash_collector/arc_crash_collector_bridge.cc
diff --git a/components/arc/crash_collector/arc_crash_collector_bridge.cc b/components/arc/crash_collector/arc_crash_collector_bridge.cc
index 61923c8bef9f66a3b383e28e541773ef7ea0fcc0..90912eaf743691709b5709317215123d85c4f8c4 100644
--- a/components/arc/crash_collector/arc_crash_collector_bridge.cc
+++ b/components/arc/crash_collector/arc_crash_collector_bridge.cc
@@ -28,11 +28,9 @@ void RunCrashReporter(const std::string& crash_type,
const std::string& board,
const std::string& cpu_abi,
mojo::edk::ScopedPlatformHandle pipe) {
- base::FileHandleMappingVector fd_map = {
- std::make_pair(pipe.get().handle, STDIN_FILENO)};
-
base::LaunchOptions options;
- options.fds_to_remap = &fd_map;
+ options.fds_to_remap.push_back(
+ std::make_pair(pipe.get().handle, STDIN_FILENO));
auto process =
base::LaunchProcess({kCrashReporterPath, "--arc_java_crash=" + crash_type,
« no previous file with comments | « chromeos/process_proxy/process_proxy.cc ('k') | components/browser_watcher/watcher_client_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698