Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4807)

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/mojo_test_connector.cc ('k') | chrome/utility/image_writer/image_writer_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome_launcher.cc
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index c1988631dfe1f9c03b21aa90c5bf76e98ba0bb7d..3f302e59cea42fb96f0d7d2966fa5e8e99838724 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -359,7 +359,6 @@ Status LaunchDesktopChrome(URLRequestContextGetter* context_getter,
#endif
#if defined(OS_POSIX)
- base::FileHandleMappingVector no_stderr;
base::ScopedFD devnull;
if (!base::CommandLine::ForCurrentProcess()->HasSwitch("verbose")) {
// Redirect stderr to /dev/null, so that Chrome log spew doesn't confuse
@@ -367,8 +366,8 @@ Status LaunchDesktopChrome(URLRequestContextGetter* context_getter,
devnull.reset(HANDLE_EINTR(open("/dev/null", O_WRONLY)));
if (!devnull.is_valid())
return Status(kUnknownError, "couldn't open /dev/null");
- no_stderr.push_back(std::make_pair(devnull.get(), STDERR_FILENO));
- options.fds_to_remap = &no_stderr;
+ options.fds_to_remap.push_back(
+ std::make_pair(devnull.get(), STDERR_FILENO));
}
#elif defined(OS_WIN)
if (!SwitchToUSKeyboardLayout())
« no previous file with comments | « chrome/test/base/mojo_test_connector.cc ('k') | chrome/utility/image_writer/image_writer_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698