Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10009)

Unified Diff: chrome/installer/util/user_experiment.cc

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/shell_integration_linux.cc ('k') | chrome/test/base/mojo_test_connector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/user_experiment.cc
diff --git a/chrome/installer/util/user_experiment.cc b/chrome/installer/util/user_experiment.cc
index a5c4d6a1e63ea58f921d8258c9430095c933fdc6..3c17b7a3a1b8e64187f602cdde502017320ff6e1 100644
--- a/chrome/installer/util/user_experiment.cc
+++ b/chrome/installer/util/user_experiment.cc
@@ -136,7 +136,8 @@ bool LaunchSetup(base::CommandLine* cmd_line, bool system_level_toast) {
// Use handle inheritance to make sure the duplicated toast results key
// gets inherited by the child process.
base::LaunchOptions options;
- options.inherit_handles = true;
+ // TODO(brettw) bug 748258: Share only explicit handles.
+ options.inherit_mode = base::LaunchOptions::Inherit::kAll;
base::Process process = base::LaunchProcess(*cmd_line, options);
return process.IsValid();
}
@@ -239,7 +240,8 @@ bool LaunchSetupAsConsoleUser(base::CommandLine* cmd_line) {
// able to use the duplicated handle above (Google Update results).
base::LaunchOptions options;
options.as_user = user_token;
- options.inherit_handles = true;
+ // TODO(brettw) bug 748258: Share only explicit handles.
+ options.inherit_mode = base::LaunchOptions::Inherit::kAll;
options.empty_desktop_name = true;
VLOG(1) << __func__ << " launching " << cmd_line->GetCommandLineString();
base::Process process = base::LaunchProcess(*cmd_line, options);
« no previous file with comments | « chrome/browser/shell_integration_linux.cc ('k') | chrome/test/base/mojo_test_connector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698