Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2878)

Unified Diff: chrome/browser/mac/relauncher.mm

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/mac/relauncher.mm
diff --git a/chrome/browser/mac/relauncher.mm b/chrome/browser/mac/relauncher.mm
index 1ad1042256f030cbba8e0ccbb90517f0c825dcf3..2521b2c8041638061db3bfb843d3d124c179e83c 100644
--- a/chrome/browser/mac/relauncher.mm
+++ b/chrome/browser/mac/relauncher.mm
@@ -130,8 +130,8 @@ bool RelaunchAppWithHelper(const std::string& helper,
// pipe. It can close the write side as soon as the relauncher process has
// forked off. The relauncher process will only use pipe_write_fd as the
// write side of the pipe. In that process, the read side will be closed by
- // base::LaunchApp because it won't be present in fd_map, and the write side
- // will be remapped to kRelauncherSyncFD by fd_map.
+ // base::LaunchApp because it won't be present in fds_to_remap, and the write
+ // side will be remapped to kRelauncherSyncFD by fds_to_remap.
base::ScopedFD pipe_read_fd(pipe_fds[0]);
base::ScopedFD pipe_write_fd(pipe_fds[1]);
@@ -143,11 +143,9 @@ bool RelaunchAppWithHelper(const std::string& helper,
kRelauncherSyncFD != STDERR_FILENO,
"kRelauncherSyncFD must not conflict with stdio fds");
- base::FileHandleMappingVector fd_map;
- fd_map.push_back(std::make_pair(pipe_write_fd.get(), kRelauncherSyncFD));
-
base::LaunchOptions options;
- options.fds_to_remap = &fd_map;
+ options.fds_to_remap.push_back(
+ std::make_pair(pipe_write_fd.get(), kRelauncherSyncFD));
if (!base::LaunchProcess(relaunch_args, options).IsValid()) {
LOG(ERROR) << "base::LaunchProcess failed";
return false;

Powered by Google App Engine
This is Rietveld 408576698