Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: base/test/launcher/test_launcher.h

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process/process_util_unittest.cc ('k') | base/test/launcher/test_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/launcher/test_launcher.h
diff --git a/base/test/launcher/test_launcher.h b/base/test/launcher/test_launcher.h
index dd6984689c6d0d5fda4e3c16158ee83e4466b4cb..3043de02d6264167494b28df4bdc10690c0a29fe 100644
--- a/base/test/launcher/test_launcher.h
+++ b/base/test/launcher/test_launcher.h
@@ -20,6 +20,7 @@
#include "base/test/launcher/test_results_tracker.h"
#include "base/time/time.h"
#include "base/timer/timer.h"
+#include "build/build_config.h"
namespace base {
@@ -89,13 +90,18 @@ class TestLauncher {
};
struct LaunchOptions {
+ LaunchOptions();
+ LaunchOptions(const LaunchOptions& other);
+ ~LaunchOptions();
+
int flags = 0;
-#if defined(OS_WIN)
// These mirror values in base::LaunchOptions, see it for details.
- HandlesToInheritVector* handles_to_inherit = nullptr;
- bool inherit_handles = false;
+#if defined(OS_WIN)
+ base::LaunchOptions::Inherit inherit_mode =
+ base::LaunchOptions::Inherit::kSpecific;
+ base::HandlesToInheritVector handles_to_inherit;
#elif defined(OS_POSIX)
- const FileHandleMappingVector* fds_to_remap = nullptr;
+ FileHandleMappingVector fds_to_remap;
#endif
};
« no previous file with comments | « base/process/process_util_unittest.cc ('k') | base/test/launcher/test_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698