Chromium Code Reviews

Unified Diff: sandbox/linux/suid/client/setuid_sandbox_host.h

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Fix Mojo launcher, review comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: sandbox/linux/suid/client/setuid_sandbox_host.h
diff --git a/sandbox/linux/suid/client/setuid_sandbox_host.h b/sandbox/linux/suid/client/setuid_sandbox_host.h
index b36480187b1a9317ae154169e049052aa435cb76..afa43de460e384cb52d94701fcdfc0205595f573 100644
--- a/sandbox/linux/suid/client/setuid_sandbox_host.h
+++ b/sandbox/linux/suid/client/setuid_sandbox_host.h
@@ -50,11 +50,12 @@ class SANDBOX_EXPORT SetuidSandboxHost {
// Set-up the launch options for launching via the setuid sandbox. Caller is
// responsible for keeping |dummy_fd| alive until LaunchProcess() completes.
- // |options| and |fds_to_remap| must not be NULL.
+ // |options| must not be NULL. This function will append to
+ // options->fds_to_remap so the caller should take care to append rather than
+ // overwrite if it has additional FDs.
// (Keeping |dummy_fd| alive is an unfortunate historical artifact of the
// chrome-sandbox ABI.)
void SetupLaunchOptions(base::LaunchOptions* options,
- base::FileHandleMappingVector* fds_to_remap,
base::ScopedFD* dummy_fd);
// Set-up the environment. This should be done prior to launching the setuid

Powered by Google App Engine