Improve process launch handle sharing API.

net/test/spawned_test_server/local_test_server_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/spawned_test_server/local_test_server.h"
 
 #include <windows.h>
 
 #include "base/base_paths.h"
 #include "base/bind.h"
@@ skipping 107 matching lines @@
   // "64-bit versions of Windows use 32-bit handles for
   // interoperability. When sharing a handle between 32-bit and 64-bit
   // applications, only the lower 32 bits are significant, so it is
   // safe to truncate the handle (when passing it from 64-bit to
   // 32-bit) or sign-extend the handle (when passing it from 32-bit to
   // 64-bit)."
   python_command.AppendArg("--startup-pipe=" +
       base::IntToString(reinterpret_cast<uintptr_t>(child_write)));
 
   base::LaunchOptions launch_options;
-  launch_options.inherit_handles = true;
+  launch_options.inherit_mode = base::LaunchOptions::Inherit::kAll;

[jschuh, 2017/07/24 19:41:27]

Leave a TODO here.

   process_ = base::LaunchProcess(python_command, launch_options);
   if (!process_.IsValid()) {
     LOG(ERROR) << "Failed to launch " << python_command.GetCommandLineString();
     ::CloseHandle(child_write);
     return false;
   }
 
   ::CloseHandle(child_write);
   return true;
 }
@@ skipping 18 matching lines @@
 
   if (!ParseServerData(server_data)) {
     LOG(ERROR) << "Could not parse server_data: " << server_data;
     return false;
   }
 
   return true;
 }
 
 }  // namespace net