Internals for testing NetInfov3 code

Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 87 matching lines @@
 #include "core/inspector/InspectorCounters.h"
 #include "core/inspector/InspectorFrontendChannel.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/inspector/InspectorOverlay.h"
 #include "core/inspector/InstrumentingAgents.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/HistoryItem.h"
 #include "core/page/Chrome.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/EventHandler.h"
+#include "core/page/NetworkStateNotifier.h"
 #include "core/page/Page.h"
 #include "core/page/PagePopupController.h"
 #include "core/page/PrintContext.h"
 #include "core/rendering/RenderLayer.h"
 #include "core/rendering/RenderMenuList.h"
 #include "core/rendering/RenderObject.h"
 #include "core/rendering/RenderTreeAsText.h"
 #include "core/rendering/RenderView.h"
 #include "core/rendering/compositing/CompositedLayerMapping.h"
 #include "core/rendering/compositing/RenderLayerCompositor.h"
 #include "core/testing/GCObservation.h"
 #include "core/workers/WorkerThread.h"
 #include "platform/ColorChooser.h"
 #include "platform/Cursor.h"
 #include "platform/Language.h"
 #include "platform/TraceEvent.h"
 #include "platform/geometry/IntRect.h"
 #include "platform/geometry/LayoutRect.h"
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/graphics/filters/FilterOperation.h"
 #include "platform/graphics/filters/FilterOperations.h"
 #include "platform/weborigin/SchemeRegistry.h"
 #include "public/platform/Platform.h"
+#include "public/platform/WebConnectionType.h"
 #include "public/platform/WebGraphicsContext3D.h"
 #include "public/platform/WebGraphicsContext3DProvider.h"
 #include "public/platform/WebLayer.h"
 #include "wtf/InstanceCounter.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/dtoa.h"
 #include "wtf/text/StringBuffer.h"
 
 namespace WebCore {
 
@@ skipping 2186 matching lines @@
 
 String Internals::textSurroundingNode(Node* node, int x, int y, unsigned long maxLength)
 {
     if (!node)
         return String();
     blink::WebPoint point(x, y);
     SurroundingText surroundingText(VisiblePosition(node->renderer()->positionForPoint(static_cast<IntPoint>(point))), maxLength);
     return surroundingText.content();
 }
 
+void Internals::setNetworkConnectionInfo(const String& type, ExceptionState& exceptionState)
+{
+    blink::WebConnectionType webtype;
+    if (type == "cellular") {
+        webtype = blink::ConnectionTypeCellular;
+    } else if (type == "bluetooth") {
+        webtype = blink::ConnectionTypeBluetooth;
+    } else if (type == "ethernet") {
+        webtype = blink::ConnectionTypeEthernet;
+    } else if (type == "wifi") {
+        webtype = blink::ConnectionTypeWifi;
+    } else if (type == "other") {
+        webtype = blink::ConnectionTypeOther;
+    } else if (type == "none") {
+        webtype = blink::ConnectionTypeNone;
+    } else {
+        exceptionState.throwDOMException(NotFoundError, ExceptionMessages::failedToEnumerate("connection type", type));
+        return;
+    }
+    networkStateNotifier().setWebConnectionType(webtype);

[adamk, 2014/05/22 15:40:32]

It looks to me like this might leak state between tests that happen to run in
the same renderer. If so, please add some resetting code to TestRunner::Reset()
to make sure each test starts out with the same value:

https://code.google.com/p/chromium/codesearch#chromium/src/content/shell/rend...

[jkarlin, 2014/05/22 17:38:02]

Good point that it changes state between runs.  One would expect the network
connection type to change with the testing environment anyway.  So layout tests
that use navigator.connection.type must be agnostic to the initial type.

[adamk, 2014/05/23 22:33:57]

Not sure what you mean by "One would expect the network connection type to
change"...we've had problems with test flakiness where someone got a test to
pass when initially landed and then test ordering changes later caused it to
fail. Given that there's a default when the process starts up (at least in
layout tests), I'd really like that to be enforced by the test runner.

Or are you saying that due to the state of the machine running these tests, the
connection type will change? Hmm, I could imagine that. But in that case adding
an Internals API seems possibly flaky (if the OS decides to send some event that
causes us to update our connection type).

 }
+}

[adamk, 2014/05/22 15:40:32]

Nit: Please add a blank line between these two braces (and give the namespace
one a comment while you're there).

[jkarlin, 2014/05/22 17:38:02]

Done.