Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2224)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

Issue 2949993002: Don't ignore manifest icons for sites that don't have a service worker. (Closed)
Patch Set: Create InstallableManager in the unit test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
index 4dc6b26cde9e37477445bb083987632044c31056..7bdf411a7ceb50deb526d02405215e55136bda5d 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
@@ -30,6 +30,7 @@ class Message;
}
class GURL;
+class InstallableManager;
struct InstallableData;
struct WebApplicationInfo;
@@ -38,8 +39,7 @@ struct WebApplicationInfo;
//
// Because of the various asynchronous calls made by this class, it is
// refcounted to prevent the class from being prematurely deleted. If the
-// pointer to the ShortcutHelper becomes invalid, the pipeline should kill
-// itself.
+// |weak_observer| pointer becomes invalid, the pipeline should kill itself.
pkotwicz 2017/06/21 17:49:32 Nit: |weak_observer_|
dominickn 2017/06/22 02:54:15 Done.
class AddToHomescreenDataFetcher
: public base::RefCounted<AddToHomescreenDataFetcher>,
public content::WebContentsObserver {
@@ -103,6 +103,9 @@ class AddToHomescreenDataFetcher
void OnDataTimedout();
// Called when InstallableManager finishes looking for a manifest and icon.
+ void OnDidGetManifestAndIcon(const InstallableData& data);
+
+ // Called when InstallableManager finishes checking for installability.
void OnDidPerformInstallableCheck(const InstallableData& data);
// Grabs the favicon for the current URL.
@@ -125,6 +128,7 @@ class AddToHomescreenDataFetcher
scoped_refptr<base::TaskRunner> background_task_runner_;
+ InstallableManager* installable_manager_;
Observer* weak_observer_;
// The icons must only be set on the UI thread for thread safety.
« no previous file with comments | « no previous file | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc » ('j') | chrome/browser/ui/tab_helpers.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698