Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/browser/ui/tab_helpers.cc

Issue 2949993002: Don't ignore manifest icons for sites that don't have a service worker. (Closed)
Patch Set: Create InstallableManager in the unit test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tab_helpers.h" 5 #include "chrome/browser/ui/tab_helpers.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
12 #include "build/build_config.h" 12 #include "build/build_config.h"
13 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 13 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
14 #include "chrome/browser/browser_process.h" 14 #include "chrome/browser/browser_process.h"
15 #include "chrome/browser/content_settings/mixed_content_settings_tab_helper.h" 15 #include "chrome/browser/content_settings/mixed_content_settings_tab_helper.h"
16 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 16 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
17 #include "chrome/browser/data_use_measurement/data_use_web_contents_observer.h" 17 #include "chrome/browser/data_use_measurement/data_use_web_contents_observer.h"
18 #include "chrome/browser/engagement/site_engagement_helper.h" 18 #include "chrome/browser/engagement/site_engagement_helper.h"
19 #include "chrome/browser/engagement/site_engagement_service.h" 19 #include "chrome/browser/engagement/site_engagement_service.h"
20 #include "chrome/browser/external_protocol/external_protocol_observer.h" 20 #include "chrome/browser/external_protocol/external_protocol_observer.h"
21 #include "chrome/browser/favicon/favicon_utils.h" 21 #include "chrome/browser/favicon/favicon_utils.h"
22 #include "chrome/browser/history/history_tab_helper.h" 22 #include "chrome/browser/history/history_tab_helper.h"
23 #include "chrome/browser/history/top_sites_factory.h" 23 #include "chrome/browser/history/top_sites_factory.h"
24 #include "chrome/browser/infobars/infobar_service.h" 24 #include "chrome/browser/infobars/infobar_service.h"
25 #include "chrome/browser/installable/installable_manager.h"
25 #include "chrome/browser/media/media_engagement_service.h" 26 #include "chrome/browser/media/media_engagement_service.h"
26 #include "chrome/browser/metrics/desktop_session_duration/desktop_session_durati on_observer.h" 27 #include "chrome/browser/metrics/desktop_session_duration/desktop_session_durati on_observer.h"
27 #include "chrome/browser/metrics/renderer_uptime_web_contents_observer.h" 28 #include "chrome/browser/metrics/renderer_uptime_web_contents_observer.h"
28 #include "chrome/browser/net/net_error_tab_helper.h" 29 #include "chrome/browser/net/net_error_tab_helper.h"
29 #include "chrome/browser/net/predictor_tab_helper.h" 30 #include "chrome/browser/net/predictor_tab_helper.h"
30 #include "chrome/browser/ntp_snippets/bookmark_last_visit_updater.h" 31 #include "chrome/browser/ntp_snippets/bookmark_last_visit_updater.h"
31 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h" 32 #include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h"
32 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 33 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
33 #include "chrome/browser/permissions/permission_request_manager.h" 34 #include "chrome/browser/permissions/permission_request_manager.h"
34 #include "chrome/browser/predictors/loading_predictor_factory.h" 35 #include "chrome/browser/predictors/loading_predictor_factory.h"
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 web_contents); 196 web_contents);
196 ExternalProtocolObserver::CreateForWebContents(web_contents); 197 ExternalProtocolObserver::CreateForWebContents(web_contents);
197 favicon::CreateContentFaviconDriverForWebContents(web_contents); 198 favicon::CreateContentFaviconDriverForWebContents(web_contents);
198 FindTabHelper::CreateForWebContents(web_contents); 199 FindTabHelper::CreateForWebContents(web_contents);
199 history::WebContentsTopSitesObserver::CreateForWebContents( 200 history::WebContentsTopSitesObserver::CreateForWebContents(
200 web_contents, TopSitesFactory::GetForProfile( 201 web_contents, TopSitesFactory::GetForProfile(
201 Profile::FromBrowserContext( 202 Profile::FromBrowserContext(
202 web_contents->GetBrowserContext())).get()); 203 web_contents->GetBrowserContext())).get());
203 HistoryTabHelper::CreateForWebContents(web_contents); 204 HistoryTabHelper::CreateForWebContents(web_contents);
204 InfoBarService::CreateForWebContents(web_contents); 205 InfoBarService::CreateForWebContents(web_contents);
206 InstallableManager::CreateForWebContents(web_contents);
pkotwicz 2017/06/21 17:49:32 We can probably remove calls to InstallableManager
dominickn 2017/06/22 02:54:15 Good point, done. Though if it's needed in unit te
205 metrics::RendererUptimeWebContentsObserver::CreateForWebContents( 207 metrics::RendererUptimeWebContentsObserver::CreateForWebContents(
206 web_contents); 208 web_contents);
207 if (content::IsBrowserSideNavigationEnabled()) 209 if (content::IsBrowserSideNavigationEnabled())
208 MixedContentSettingsTabHelper::CreateForWebContents(web_contents); 210 MixedContentSettingsTabHelper::CreateForWebContents(web_contents);
209 NavigationCorrectionTabObserver::CreateForWebContents(web_contents); 211 NavigationCorrectionTabObserver::CreateForWebContents(web_contents);
210 NavigationMetricsRecorder::CreateForWebContents(web_contents); 212 NavigationMetricsRecorder::CreateForWebContents(web_contents);
211 chrome::InitializePageLoadMetricsForWebContents(web_contents, create_params); 213 chrome::InitializePageLoadMetricsForWebContents(web_contents, create_params);
212 PermissionRequestManager::CreateForWebContents(web_contents); 214 PermissionRequestManager::CreateForWebContents(web_contents);
213 PopupBlockerTabHelper::CreateForWebContents(web_contents); 215 PopupBlockerTabHelper::CreateForWebContents(web_contents);
214 PrefsTabHelper::CreateForWebContents(web_contents); 216 PrefsTabHelper::CreateForWebContents(web_contents);
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 319
318 if (tracing::NavigationTracingObserver::IsEnabled()) 320 if (tracing::NavigationTracingObserver::IsEnabled())
319 tracing::NavigationTracingObserver::CreateForWebContents(web_contents); 321 tracing::NavigationTracingObserver::CreateForWebContents(web_contents);
320 322
321 if (MediaEngagementService::IsEnabled()) 323 if (MediaEngagementService::IsEnabled())
322 MediaEngagementService::CreateWebContentsObserver(web_contents); 324 MediaEngagementService::CreateWebContentsObserver(web_contents);
323 325
324 if (ResourceCoordinatorWebContentsObserver::IsEnabled()) 326 if (ResourceCoordinatorWebContentsObserver::IsEnabled())
325 ResourceCoordinatorWebContentsObserver::CreateForWebContents(web_contents); 327 ResourceCoordinatorWebContentsObserver::CreateForWebContents(web_contents);
326 } 328 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698